Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123

Iloer · 2020-03-12T22:27:52Z

#102 Implemented PullRequest decoration to AzureDevOps server
(only Git Repository, without TFVC)

Sonarqube 8.1 removed the concept of short and long lived branches, instead simplifying the setup to either `BRANCH` or `PULL_REQUEST`. This release of Sonarqube also moved the management of Pull Request decoration into a standard User Interface calling a set of 'ALM' services that provide the management of decorators, and the binding of each project to these decorators. However the implementation of these services is not included in the Community Edition of Sonarqube, although the UI is made visible based on the presence of the branch management components provided by this plugin. This change therefore introduces the services required to support UI components for the management of Pull Request decoration, as well as updating the handling of the configuration and loading of branches to support the removal of the SHORT/LONG branch constructs. As these changes require the reference of classes that were not present in older version of Sonarqube (namely `AlmSettingsDao` and `ProjectAlmSettingsDao`), the compatibility interfaces for these versions have been removed, as well as any methods and classes that existed purely to allow these versions to be supported by this plugin. Given the standard UI provides a restricted set of fields for creating and binding each Pull Request decorator, some of the patterns that were previously used by this plugin for configuring the decoration of Pull Requests do not fit into this UI, and were awkward to find/manage when moved to another screen in the UI. This results in the configuration for disabling the addition and removing of comments on Merge Requests being removed from the plugin, with the Gitlab decorator removing the deleting of old comments since this was leading to discussion boxes being shown in Gitlab with no content, and the BitBucket decorator removing since it can't work out which user posted comments based purely on the configuration provided by Sonarqube. To ensure the UI works for all configuration options, the services for configuring and binding Azure DevOps configuration have been included in this change-set, although no decorator currently exists for this ALM, so any project attempting to use this configuration will get a warning appear in the CE logs when attempting to use this decorator. Similarly, as the UI does not provide any options for configuring the URL for the Gitlab API, or the Slug/name of the project on the binding, a `Sensor` has been added into the scanner to detect these properties from injection by the Gitlab CI Runner, as well as injection directly from scanner arguments of `com.github.mc1arke.sonarqube.plugin.branch.pullrequest.gitlab.url` and `com.github.mc1arke.sonarqube.plugin.branch.pullrequest.gitlab.repositorySlug` for the repository URL and repository-name configuration entries.

Fixes mc1arke#84

Fixes mc1arke#85

The Github ALM Binding Web Service uses the `AlmRepo` field to store the repository name, but the Github decorator was using `AlmSlug` to try and retrieve the repository name, so was getting a `null` value back and failing to find a matching repository. Switching to using `AlmRepo` in the decorator overcomes this issues.

Initial commit with test

add getContextProperty method

fix test

Add POST PR Status

mc1arke#102 add Azure object class and small refactoring

mc1arke#102 add azure thread with issue

mc1arke#102 add: closed issue in sonar, resolve in Azure

mc1arke#102 add unit tests

mc1arke#102 small refactoring

mc1arke#102 Fix unit test

remove unused code

remove star import

...ain/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/PullRequestPostAnalysisTask.java

mc1arke

Thanks for your contribution!

I've put a few comments on specific lines that generally apply to your whole change. Could we aim for immutable classes, and low visibility methods and fields where possible.

I've not gone through and functionally reviewed your changes yet given there are quite a few classes will need modified to meet the above ruquest.

Could you also squash your commits to a single commit per feature (i.e. this PR should probably be a single commit), and ensure your commit message follows https://github.com/RomuloOliveira/commit-messages-guide.

mc1arke · 2020-03-13T12:42:14Z

src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/Comment.java

+    /**
+     * The ID of the parent comment. This is used for replies.
+     */
+    public void setParentCommentId(Integer value){


Can we make this object immutable?

mc1arke · 2020-03-13T12:42:49Z

...va/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentPosition.java

+import java.io.Serializable;
+
+public class CommentPosition implements Serializable {
+    private Integer line;


int rather than Integer, or is this nullalble?

mc1arke · 2020-03-13T12:42:58Z

...va/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentPosition.java

+
+    public CommentPosition(Integer line, Integer offset){
+        this.line = line;
+        this.offset = offset + 1;


Char numbering in line in Azure PullRequest starts at "0", while in SonarQube starts at "1"

mc1arke · 2020-03-13T12:43:39Z

.../github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/CommentThreadResponse.java

+import com.fasterxml.jackson.annotation.JsonProperty;
+
+public class CommentThreadResponse {
+    private CommentThread[] value;


mc1arke · 2020-03-13T12:44:25Z

...m/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/GitPullRequestStatus.java

+    /**
+     * ID of the iteration to associate status with. Minimum value is 1.
+     */
+    public Integer iterationId = null;


These should be private, and access through getters, with initialisation in the constructor

mc1arke · 2020-03-13T12:45:32Z

...m/github/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/PropertiesCollection.java

@@ -0,0 +1,5 @@
+package com.github.mc1arke.sonarqube.plugin.ce.pullrequest.azuredevops.model;
+
+public class PropertiesCollection {


What's the intent of this class? It contains no fields or methods

mc1arke · 2020-03-13T12:46:04Z

...hub/mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/enums/CommentThreadStatus.java

+    /**
+     * The thread status is unknown.
+     */
+    unknown,


Naming conventions are to have enum fields in upper-case. Is there any reason that can't be followed here?

mc1arke · 2020-03-13T12:46:26Z

...rke/sonarqube/plugin/ce/pullrequest/azuredevops/model/mappers/CommentThreadStatusMapper.java

+import com.github.mc1arke.sonarqube.plugin.ce.pullrequest.azuredevops.model.enums.CommentThreadStatus;
+import org.sonar.api.issue.Issue;
+
+import static org.sonar.api.issue.Issue.*;


Please don't use star imports

mc1arke · 2020-03-13T12:46:38Z

...rke/sonarqube/plugin/ce/pullrequest/azuredevops/model/mappers/CommentThreadStatusMapper.java

+import static org.sonar.api.issue.Issue.*;
+
+
+public class CommentThreadStatusMapper {


final if the constructor is private

mc1arke · 2020-03-13T12:46:58Z

.../mc1arke/sonarqube/plugin/ce/pullrequest/azuredevops/model/mappers/GitStatusStateMapper.java

+import com.github.mc1arke.sonarqube.plugin.ce.pullrequest.azuredevops.model.enums.GitStatusState;
+import org.sonar.api.ce.posttask.QualityGate;
+
+public class GitStatusStateMapper {


final if the constructor is private

mc1arke#102 comment fixes

…qube-community-branch-plugin into issue/102-8_1support

…be 8.1 version

…qube-community-branch-plugin into issue/102-8_1support

Iloer · 2020-03-16T05:57:55Z

@mc1arke I am tried rebase, but something went wrong, please help squash the commits

mc1arke#102 enum to UPPERCASE

bambuca · 2020-03-20T00:54:31Z

Can it be used also with TFS on premise?

Iloer · 2020-03-20T05:39:17Z

Yes, tested on AzureDevOps server 2019 (on premise) on API version 5.0-preview.1
Compatible with API version 4.0-preview
here is the mapping API and product versions

Iloer · 2020-03-24T05:31:35Z

@mc1arke please see this pullrequets

mc1arke#102 attempt to close comment in AzureDevOps by issue.key

bambuca · 2020-05-07T17:03:17Z

What about this PR? This is my dream PR 🥇

mc1arke and others added 22 commits February 2, 2020 21:53

[GITLAB] URL needs to point to the GitLab API

a228fc0

Fixes mc1arke#84

[Gitlab] reenable deletion of comments

3dfad7d

[GITLAB] allow overrding of autodetected gitlab ci values

5776c97

[GITLAB] auto config branch/MR

edb6e12

[GITLAB] use same property names as sonar developer edition

4090510

Fix adding discussions for gitlab

2d85835

[GITLAB] don't fail, if no new coverage condition is provided

9e9c59c

Fixes mc1arke#85

[GITLAB] support multiple pipelines on a single commit

cae9131

[email protected]

5d4b432

Initial commit with test

[email protected]

a93110a

add getContextProperty method

[email protected]

5f327b0

fix test

[email protected]

e04f486

Add POST PR Status

[email protected]

3e7d57c

mc1arke#102 add Azure object class and small refactoring

[email protected]

b42d8e6

mc1arke#102 add azure thread with issue

[email protected]

174483a

mc1arke#102 add: closed issue in sonar, resolve in Azure

[email protected]

05a5224

mc1arke#102 add unit tests

[email protected]

885e1b3

mc1arke#102 small refactoring

[email protected]

e197ff8

mc1arke#102 Fix unit test

[email protected]

db4f93e

remove unused code

[email protected]

dc9a1cc

remove star import

bambuca reviewed Mar 13, 2020

View reviewed changes

...ain/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/PullRequestPostAnalysisTask.java Outdated Show resolved Hide resolved

mc1arke requested changes Mar 13, 2020

View reviewed changes

Iloer and others added 5 commits March 15, 2020 03:22

[email protected]

8670a7f

mc1arke#102 comment fixes

[email protected]

7c6d8a1

Merge branch 'issue/102-8_1support' of https://github.com/Iloer/sonar…

6903c45

…qube-community-branch-plugin into issue/102-8_1support

mc1arke#102 Add support AzureDevOps PullRequest decoration on SonarQu…

fd58369

…be 8.1 version

Merge branch 'issue/102-8_1support' of https://github.com/Iloer/sonar…

0289c4f

…qube-community-branch-plugin into issue/102-8_1support

[email protected]

7401aa3

mc1arke#102 enum to UPPERCASE

Iloer changed the title ~~Issue/102 8 1support~~ Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) Mar 27, 2020

[email protected]

935afff

mc1arke#102 attempt to close comment in AzureDevOps by issue.key

mc1arke force-pushed the sq-8_1-support branch 2 times, most recently from a34a666 to bf136e4 Compare April 20, 2020 06:10

mc1arke mentioned this pull request Apr 24, 2020

Not Able to integrate ALM on Azure Devops Server #152

Closed

mc1arke force-pushed the sq-8_1-support branch 2 times, most recently from 11eac55 to 9b3aedf Compare May 17, 2020 17:24

mc1arke force-pushed the sq-8_1-support branch 3 times, most recently from 2d029de to 89b5982 Compare June 7, 2020 13:39

mc1arke closed this Jun 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123

Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123

Iloer commented Mar 12, 2020

mc1arke left a comment

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 14, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020 •

edited

Loading

mc1arke Mar 13, 2020

Iloer Mar 16, 2020

Iloer commented Mar 16, 2020 •

edited

Loading

bambuca commented Mar 20, 2020

Iloer commented Mar 20, 2020 •

edited

Loading

Iloer commented Mar 24, 2020

bambuca commented May 7, 2020

		@@ -0,0 +1,5 @@
		package com.github.mc1arke.sonarqube.plugin.ce.pullrequest.azuredevops.model;

		public class PropertiesCollection {

		import static org.sonar.api.issue.Issue.*;


		public class CommentThreadStatusMapper {

Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123

Implemented PullRequest decoration to AzureDevOps server (issue/102 8 1support) #123

Conversation

Iloer commented Mar 12, 2020

mc1arke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Iloer commented Mar 16, 2020 • edited Loading

bambuca commented Mar 20, 2020

Iloer commented Mar 20, 2020 • edited Loading

Iloer commented Mar 24, 2020

bambuca commented May 7, 2020

Iloer Mar 16, 2020 •

edited

Loading

Iloer Mar 16, 2020 •

edited

Loading

Iloer Mar 14, 2020 •

edited

Loading

Iloer Mar 16, 2020 •

edited

Loading

Iloer Mar 16, 2020 •

edited

Loading

Iloer Mar 16, 2020 •

edited

Loading

Iloer Mar 16, 2020 •

edited

Loading

Iloer Mar 16, 2020 •

edited

Loading

Iloer commented Mar 16, 2020 •

edited

Loading

Iloer commented Mar 20, 2020 •

edited

Loading